[NO FEATURE FLAG] feat: migrate assets domain to use the AssetsController - #78
Closed
ulissesferreira wants to merge 17 commits into
Closed
[NO FEATURE FLAG] feat: migrate assets domain to use the AssetsController#78ulissesferreira wants to merge 17 commits into
ulissesferreira wants to merge 17 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Derived from ASSETS-2-feature-flagged. Strips the remote-feature-flag and TRON_ASSETS_MIGRATION_STAGE env surface. Fungibles always read via AssetsController:getAsset. Protocol assets remain Snap-owned via isSnapOwnedAsset. Removed: assetsMigrationMode.ts, its test, and RemoteFeatureFlagController:getState messenger action.
ulissesferreira
temporarily deployed
to
default-branch
July 31, 2026 00:18 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
…ation Add getAssetsMetadata and batch read tests so global coverage thresholds pass after removing fungible extraction from account sync.
Align repository writes with controller-owned fungibles: filter the save payload the same way as keyring events.
Contributor
Author
|
@cursoragent Do the following
|
|
I applied both review requests on Handler folders
AssetsService renames
Imports/usages and changelog were updated. Full package suite: 895 tests passed.   |
Move assets, cronjob, keyring, and user-input handlers into dedicated folders, and rename AssetsService account asset readers to getAccountAssetByID, getAccountAssetsByIDs, and getAccountAssets. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
ulissesferreira
changed the title
ulissesferreira
changed the title
ulissesferreira
marked this pull request as draft
July 31, 2026 10:32
Expose instant fungible asset listing via AssetsController so snap flows can read controller-backed balances by network without on-chain sync.
This was referenced Jul 31, 2026
Contributor
Author
jeremytsng
pushed a commit
that referenced
this pull request
Aug 5, 2026
## Explanation Adds transaction expiration (time-bounds maxTime) handling to prevent simulation/validation of expired Stellar envelopes, wiring the logic through the Transaction wrapper and TransactionSimulator, and covering it with tests. <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetsControlleractions from MetaMask Core.AssetsControllerunconditionally (no feature flag), usingSNAP_OWNED_ASSETSandmapControllerAssetto map controller state into snap-owned assets.AssetsServiceand tests by removing the migration-mode / feature-flag branching path.Test plan
yarn workspace @metamask/tron-wallet-snap buildyarn workspace @metamask/tron-wallet-snap run testAssetsControllerin all environmentsMade with Cursor